Incorrect escaping of character in number format

aVadim483 / fast-excel-writer

Lightweight and very fast XLSX Excel Spreadsheet Writer in PHP

MIT License

142 stars 26 forks source link

Incorrect escaping of character in number format #24

Closed nickicastillo closed 12 months ago

nickicastillo commented 12 months ago

Hi,

When a character is preceded with an asterisk (*), in number format, shouldn't be escaped. The asterisk means to repeat a character so that the width of the number fills the column, and it takes that character as literal.

https://support.microsoft.com/en-au/office/number-format-codes-5026bbd6-04bc-48cd-bf33-80f18b4eae68#ID0EDN

The function that returns the escaped string: avadim\FastExcelWriter\Style::numberFormatStandardized

Hope it helps.

aVadim483 commented 12 months ago

Numeric formats do not use the asterisk character (*), but the hash symbol (#)

aVadim483 commented 12 months ago

Oh, sorry, I understand what you mean, you're right, I'll fix it