search

aXe1 / gnome-shell-extension-maximized-by-default

GNOME Shell extension that made windows maximized on start.
https://extensions.gnome.org/extension/1193/maximized-by-default/
MIT License
12 stars 14 forks source link

Incorrectly maximizes drop down menus and moves some dialogues to top left #3

Open osen opened 5 years ago

osen commented 5 years ago

Hello,

This extension is a nice idea; Gnome 3 these days does seem to drive a user towards using maximized windows.

However currently the extension seems to also cause drop down menus (such as the help menu from gnome-terminal) to maximize which is a little bit odd. Also many fixed sized dialogs cannot maximize so they get put at top left 0,0. These kinds of issues are very similar to those found in most tiling window managers. The fix is usually to ignore transient windows or those with a fixed size (that cannot maximize anyway).

Possibly we want a check if(win.get_transient_for() == null) or if(win.can_maximize() == true)

Unfortunately I have tried both of these; and I cannot seem to solve it. I am not even sure if "win" is a GtkWindow, Javascript doesn't exactly self document itself ;)

Any suggestions?

matthijskooijman commented 5 years ago

This looks like a duplicate of #2, for which I'm preparing a fix now using can_maximize(). However, it seems you're saying this does not work for you in these cases. Could it perhaps that these windows remember their maximized state? I've fixed that by explicitly unmaximizing windows, see also the comments at #2.

Can you be a bit more clear on when this problem occurs? I've tried gnome-terminal, but that does not have a help menu, just a help menu option:

image

Selecting help opens up a regular window that can (and should) be maximized normally? Is your version different?

Could you test my code from #4 and see if that helps for you as well?

matthijskooijman commented 5 years ago

I found that gnome-terminal has a menubar as well (disabled by default), but the "Help" dropdown menu in there seems to behave properly as well (without any fixes).

Were you referring to the about menu, perhaps? That is maximized without this fix, but shown normally with #4 applied?