search

aXenDeveloper / ips-app-advanced-serverlist

(IPS App) This app shows servers information from GameQ library.
GNU General Public License v3.0
18 stars 11 forks source link

Update Servers.php form #71

Closed szalikdev closed 1 year ago

szalikdev commented 1 year ago

Changed \Helpers\Form\Text to \Node which displays forums and allows user to specify forum instead of pasting url to that forum.

image

aXenDeveloper commented 1 year ago

Hi, Thanks for the PR, but you don't use forum_id in app. It's just field in database.

szalikdev commented 1 year ago

Hi, Thanks for the PR, but you don't use forum_id in app. It's just field in database.

I didn't want to remove url_forum to replace it with ID and then rework whole system, this seemed easier to do and doesn't do any harm.

aXenDeveloper commented 1 year ago

I didn't want to remove url_forum to replace it with ID and then rework whole system, this seemed easier to do and doesn't do any harm.

Ok, but I still don't get it why this feature would help.