Colour indicators in report

GoogleCodeExporter commented 9 years ago

What steps will reproduce the problem?
1.generate a report 

What is the expected output? What do you see instead?
The bars visualising the coverage should have a color that indicates the status 
of coverage. At the moment they are always in green colour, for 0% and for 100% 
coverage. Besidfe that, it would be nice if thresholds are user-defineable.

What version of the product are you using? On what operating system?
0.5, Windows

Please provide any additional information below.

nice tool

Original issue reported on code.google.com by dael...@gmail.com on 17 Aug 2010 at 8:13

GoogleCodeExporter commented 9 years ago

I found the bug, in Src.java:
public String getBranchCoverageStyle() {
                String bc = getBranchCoverage();
                return bc.equals("N/A") ? "class='na' style='width:100px'" : "class='greenbar' style='width:" + bc + "px'";
        }

        public String getFunctionCoverageStyle() {
                String fc = getFunctionCoverage();
                return fc.endsWith("N/A") ? "class='na' style='width:100px'" : "class='greenbar' style='width:" + fc + "px'";
        }

You have to round the values for fc and bc to fixed point integers.

Original comment by dael...@gmail.com on 18 Aug 2010 at 8:26

GoogleCodeExporter commented 9 years ago

I can not submit patches because I am not able to build and verify this change.

c:\dagr2587\Projects\bullshtml>ant packagewindow
Buildfile: c:\dagr2587\Projects\bullshtml\build.xml

init:

build-project:
    [echo] bullshtml: c:\dagr2587\Projects\bullshtml\build.xml
    [javac] c:\dagr2587\Projects\bullshtml\build.xml:28: warning: includeantruntime' was not set, defaulting to build.sysclasspath=last; set to false for repeatable builds
    [javac] Compiling 7 source files to c:\dagr2587\Projects\bullshtml\bin
    [javac] c:\dagr2587\Projects\bullshtml\src\com\junoyoon\SrcDir.java:22: package com.sun.xml.internal.ws.util does not exist
    [javac] import com.sun.xml.internal.ws.util.StringUtils;
    [javac]                                    ^
    [javac] 1 error

BUILD FAILED
c:\dagr2587\Projects\bullshtml\build.xml:28: Compile failed; see the compiler 
error output for details.

Original comment by dael...@gmail.com on 18 Aug 2010 at 9:10

GoogleCodeExporter commented 9 years ago

This doesn't seem to be a problem on Linux.

It looks like your build is failing just because of the "import 
com.sun.xml.internal.ws.util.StringUtils;"

I have it loaded in Eclipse, and it said that that import is unused, so you 
should be able to just delete that line.

Original comment by roja...@gmail.com on 18 Aug 2010 at 6:22

GoogleCodeExporter commented 9 years ago

OK, I will try. Can you fix the css-width issue described above?

Original comment by dael...@gmail.com on 18 Aug 2010 at 7:30

GoogleCodeExporter commented 9 years ago

I fixed the issue with missing percentage bars. The modified file is attached. 
Maybe you can do it in a better way...

Original comment by dael...@gmail.com on 19 Aug 2010 at 6:29

Attachments:

Src.java

GoogleCodeExporter commented 9 years ago

Thanks for submitting bugs. I'll fix it and release version 1.0 this month.

1.0 version includes various feature including speed up and full clover result 
output.

Original comment by junoy...@gmail.com on 26 Sep 2010 at 10:19

GoogleCodeExporter commented 9 years ago

Thanks, I am looking forward the new release

Original comment by dael...@gmail.com on 30 Sep 2010 at 5:34

GoogleCodeExporter commented 9 years ago

Now 1.0 vesion is available. please check.

Original comment by junoy...@gmail.com on 6 Oct 2010 at 5:05

Changed state: Fixed

aYaFish / bullshtml

Colour indicators in report #3