search

aaOpenSource / aaLog

A library and example programs for reading the standard SMC log file format
MIT License
13 stars 15 forks source link

Read aaLGX files #14

Closed logic-danderson closed 9 years ago

logic-danderson commented 9 years ago

The file format for an aaLGX file that is exported from the System Management Console is a little bit different than the real time log file format. So this is for adding a class called aaLgxReader that can read those files. There's also a new project called aaLogReader.Tests that contain some unit tests for aaLgxReader.

Since both aaLogReader and aaLgxReader use the GetFQDN() functionality, this update also adds a helper class called Fqdn to provide that method so the code could be shared between the two readers. And aaLogReader was updated to use the shared code to keep things DRY.

arobinsongit commented 9 years ago

Thanks for the PR! I'll try to review this as soon as I can but may be a week or so. I also love the idea that you included unit tests. That's a big missing piece and I'm glad someone took this on. I've never done unit tests before but I know they are terribly necessary. I'll model mine off of these.

Thanks again.

logic-danderson commented 9 years ago

Andy:

Sure, happy to help!

Thanks for starting the project and making it public. That's awesome.

David Anderson

From: Andrew Robinson [mailto:notifications@github.com] Sent: Friday, September 4, 2015 2:45 PM To: aaOpenSource/aaLog aaLog@noreply.github.com Cc: David Anderson danderson@logic-control.com Subject: Re: [aaLog] Read aaLGX files (#14)

Thanks for the PR! I'll try to review this as soon as I can but may be a week or so. I also love the idea that you included unit tests. That's a big missing piece and I'm glad someone took this on. I've never done unit tests before but I know they are terribly necessary. I'll model mine off of these.

Thanks again.

— Reply to this email directly or view it on GitHubhttps://github.com/aaOpenSource/aaLog/pull/14#issuecomment-137836601.