search

aaOpenSource / aaLog

A library and example programs for reading the standard SMC log file format
MIT License
13 stars 15 forks source link

Remove log4net configuration command #21

Closed logic-danderson closed 8 years ago

logic-danderson commented 8 years ago

This line should be removed from aaLogReader:

[assembly: log4net.Config.XmlConfigurator(ConfigFile = "log.config", Watch = true)]

In my opinion that belongs in the hosting executable, not the library. The way it stands now the library is hard coded to use log.config, and maybe that's not what the application developer prefers.

I tested it and logging still works without this line in aaLogReader as long as the hosting app is configured correctly.

arobinsongit commented 8 years ago

Merge complete. Closing Issue.