Refactor to eliminate some unnecessary `goto`s and fix some warnings - Githubissues

aaaaaa123456789 / libplum

Image-handling library that allows reading and writing common image file formats

The Unlicense

12 stars 6 forks source link

Refactor to eliminate some unnecessary `goto`s and fix some warnings #1

Closed Rangi42 closed 2 years ago

Rangi42 commented 3 years ago

The remaining gotos mostly follow standard patterns, like breaking out of nested loops/switches, or cleaning up allocated resources before returning.

With -Wall -Wextra -pedantic -Wno-parentheses -Wno-implicit-fallthrough -Wno-dangling-else -Wno-sign-compare -Wno-pointer-sign -Wno-unused-parameter, the only warnings that occur are:

-Wmaybe-uninitialized complains about found in find_PNG_reference, and about red, green, blue, alpha, gray in plum_load_image
-Wclobbered complains about out and buffer in plum_store_image

Diff: https://github.com/aaaaaa123456789/libplum/pull/1/files?w=1

Rangi42 commented 2 years ago

This pull request is free and unencumbered software released into the public domain, under the same Unlicense as libplum.