aaachen / IMDb-Obsidian

A simple plugin for syncing movies from IMDb to Obsidian
MIT License
10 stars 1 forks source link

Sanitize invalid file names #2

Closed cyb3rsyph0n closed 4 months ago

cyb3rsyph0n commented 4 months ago

This adds the option to automatically sanitize invalid file names that may be created from movie titles such as "The Lord of the Rings: The Return of the King"

aaachen commented 4 months ago

Thanks for catching this! I believe better option is for user to specify a replacement character and default to "-" if not set, since invalid characters will always break file creation, otherwise lgtm

cyb3rsyph0n commented 4 months ago

@aaachen I've updated per your recommendation and changed the name to make a little more sense now that it will always replace invalid characters.

aaachen commented 4 months ago

Lgtm, thanks for making the change! I'd release it after I figure out the process