search

aabc / equihash-zcash-c

Equihash solver port from C++ to C for Zcash
33 stars 58 forks source link

equihash verification #5

Open L0gi opened 6 years ago

L0gi commented 6 years ago

Hi,

I assume this is the origin of this equihash implementation port to c I have stumbled upon in several other projects?

If so, I believe my request is best directed and solved here.

Am I missing something, or does this port not verify the algorithm binding condition (strict (i.e. no duplication in indices) lexicographical ordering + leading zeroes in 'subsolutions')?

Given that several mining pool projects seem to have adopted this code, I could see there being potentially some problems depending on how their share payout is set up, if rogue miners decide to take advantage of amortization costs submitting solutions that wouldn't be accepted by the network, but this verifier code seems to allow.

aabc commented 6 years ago

It's assumed that Wagner's algorithm provides just the correctly bound solutions.

I also doubt that many miners use this implementation since there is already (in 2016) much more optimized versions after competition.