search

aablsk / bank-of-anthos

Anthos sample application for retail banking
https://bank-of-anthos.xyz
Apache License 2.0
2 stars 2 forks source link

Rework config #9

Open aablsk opened 2 years ago

aablsk commented 2 years ago

Describe request or inquiry

@aablsk add comments from olivier and brian

What purpose/environment will this feature serve?

aablsk commented 2 years ago

_"I don't think central config should be a required module of any of the deployable units as it will cause a developer doing cd src/accounts; skaffold dev to overwrite the config that's in the cluster. The config module should be required by the root skaffold.yaml.

An alternative, the config module could guard deploy the config.yaml etc by using a profile, and that profile can be made active-by-default in the root skaffold.yaml. Then a dev could run cd src/accounts; skaffold dev -p include-config if they really wanted to deploy that central config.

It's also worth revisiting uses of this central config and making the individual deployment units be resilient to the absence of this central config. They should loudly log that the central config is missing though."_