search

aabounegm / cast

A podcast listening progressive web app with all-around automated quality assurance
https://cast-iu.pages.dev
MIT License
22 stars 2 forks source link

Remove the code that was pausing playback while scrubbing #244

Closed illright closed 2 years ago

illright commented 2 years ago

Closes #231

We previously wrote some code that would pause the playback while dragging the scrubbing bar, but turns out it's a problem for Firefox who dispatches yet another input event after the pointerup event, which is what was causing the pause.

I tried all sorts of solutions, all sorts of state tracking, some of that would fix the issue but introduce a worse one in one of the browsers. This behaviour seems to be the most stable and harmless. Moreover, Firefox doesn't play while you scrub, only Chrome does, but it's not a problem either way

codecov-commenter commented 2 years ago

Codecov Report

Merging #244 (938b183) into main (a70b1aa) will decrease coverage by 0.08%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
- Coverage   60.00%   59.91%   -0.09%     
==========================================
  Files          75       75              
  Lines         675      676       +1     
  Branches      202      200       -2     
==========================================
  Hits          405      405              
- Misses        257      258       +1     
  Partials       13       13
Impacted Files Coverage Δ
...features/playback-controls/ui/scrubbing-bar.svelte 100.00% <100.00%> (ø)
src/lib/entities/audio/model/audio-instance.ts 45.45% <0.00%> (-1.43%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a70b1aa...938b183. Read the comment docs.