search

aacotroneo / laravel-saml2

A Laravel 5 package for Saml2 integration as a SP (service provider) based on the simple OneLogin toolkit
MIT License
564 stars 237 forks source link

Laravel 8 #236

Open tomasdelvechio opened 3 years ago

tomasdelvechio commented 3 years ago

I could use this library with laravel 8. It could be clarified in the README that the support is for all Laravel versions.

yasharrow commented 2 years ago

I could use this library with laravel 8. It could be clarified in the README that the support is for all Laravel versions.

@tomasdelvechio Did you get any error like below? in Laravel8 + PHP8.0

image image

tomasdelvechio commented 2 years ago

@yasharrow I dont remember any error, but I check this tomorrow

yasharrow commented 2 years ago

@yasharrow I dont remember any error, but I check this tomorrow

@tomasdelvechio Did you get a chance to check on above?

tomasdelvechio commented 2 years ago

@tomasdelvechio Did you get a chance to check on above?

Sorry, I forgot to comment. I don't get this error in my installation.

hackerkok commented 2 years ago

@tomasdelvechio Trying to use the library with Laravel 8 too. Everything works, but session does not persist after user login in the event listener. Did you have any similar issues? How did you solve them?

tomasdelvechio commented 2 years ago

@tomasdelvechio Trying to use the library with Laravel 8 too. Everything works, but session does not persist after user login in the event listener. Did you have any similar issues? How did you solve them?

I didn't keep testing this library. I had only tested that it worked in Laravel 8 and returned the correct user after the SAML process. In fact I don't know how to link that with a Laravel session.

sandervdo commented 2 years ago

@hackerkok have you checked this part of the README file? I forgot to do that step for some projects, resulting in the problem you describe.

hackerkok commented 2 years ago

@hackerkok have you checked this part of the README file? I forgot to do that step for some projects, resulting in the problem you describe.

My problem was that I was not storing the user in the db. After storing the logged in user, my problem was solved. (Sorry for the late reply)

similar issue here https://github.com/aacotroneo/laravel-saml2/issues/39#issuecomment-962670925