aadcg / emacs-yeis

Yeis's Emacs' Input Switcher
GNU General Public License v3.0
19 stars 2 forks source link

Package linting issues #1

Closed protesilaos closed 4 years ago

protesilaos commented 4 years ago

Hi @aadcg! Thank you for this package. You would benefit in your dev work by using a linter for Emacs packaging conventions.

This is a possible way to go, depending on whether you use those front-ends.

(use-package flycheck-package
  :ensure
  :after flycheck
  :config
  (flycheck-package-setup))

(use-package package-lint-flymake
  :ensure
  :after flymake
  :config
  (package-lint-flymake-setup))
aadcg commented 4 years ago

Hi @protesilaos! Thank your for providing me a ready linter configuration from which yeis will definitely benefit.

I'm wondering if have seen something in the elisp code that caught your attention or if this is just a general recommendation.

I have run the linting tool and have made some corrections (check the latest commit).

protesilaos commented 4 years ago

It was just for the general feedback the linter gives.

aadcg commented 4 years ago

Thanks again. Closing the issue.

protesilaos commented 4 years ago

You are welcome!