vverma022 commented 3 months ago

Topic Slider Changes

Description

Fixes the Bug where the Topic's with 0 posts are not shown in the topic slider and the slider is sorted in descending order.

Resolves #256

Fixes #241
Closes #241

Type of Change

Bug fix (non-breaking change which fixes an issue)

Changes

Added a sorting on the TagRouter.get which where the tags now will be fetched and sent in descending order on the basis of posts associated with them.
In the font-end while fetching the tags using fetch-topic hook a filter has been added which filters the posts and shows only the ones with more than 0 posts.
To achieve the above the backend now sends 3 objects id, name and count which is the count of the number of posts in each topic. this enables us to filter them and can also be used for implementing other features like topic post count etc. The interface was also modified to accept a count.

Screenshots/Recordings

Checklist before requesting a review

have performed a self-review of my code
I assure there are no similar/duplicate pull requests regarding the same issue
My changes follow the project's coding guidelines and best practices
Code is formatted properly and lint check passes successfully
have made corresponding changes to the documentation (if applicable)

Additional Notes

The reason for such is hybrid approach is because when the backend route was implementing the filter to send only topics with > 0 posts other components which are using that route were affected for example the component which lets you select which topic a post should be associated with etc.

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
medium-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 27, 2024 7:27pm

aadeshkulkarni commented 2 months ago

@vverma022 - The tags slider isn't shown even though the API returns data.

vverma022 commented 2 months ago

@vverma022 - The tags slider isn't shown even though the API returns data.

<img alt="Screenshot 2024-09-04 at 12 22 50 PM" width="1796" src="https://private-user-images.githubusercontent.com/67855887/364256769-5a7916d2-793b-4a12-84f2-f221f67cdbbd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU5ODc1NDgsIm5iZiI6MTcyNTk4NzI0OCwicGF0aCI6Ii82Nzg1NTg4Ny8zNjQyNTY3NjktNWE3OTE2ZDItNzkzYi00YTEyLTg0ZjItZjIyMWY2N2NkYmJkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEwVDE2NTQwOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThjNWI2NWEwNGM5YWYwMWFiMDg3YjZhM2VhMWQ1YTAwMTU2ZTI5NTBhMTA5MzBmYWNiNmNjZDhkYWZhYzU1ODcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.nyJ4Ab

https://github.com/user-attachments/assets/ae9a9142-1aff-43d7-a8da-e78625000100

FYA3e0aYIGg7uqnFC89d5rAuelj6s_7Fyvqq4">

I can't seem to find the problem as it's working fine for me. I'm able to filter the tags and show only the ones with posts > 0 and in desending order.

aadeshkulkarni commented 2 weeks ago

frontend undergoing redesign. this is paused for the moment. apologies.

aadeshkulkarni / figuringout

Fix issue 256: Bugfix | Tags with 0 posts #259