Open Adi-K-Coding opened 2 years ago
Critique for group:
Adi - Positives:
Improvement:
Score: 5.75/6 Nice job!
Aadit - Positives:
Rohan - Positives:
Improvement:
Score 5.75/6 Awesome effort!
Link to Adi's Video: https://www.loom.com/share/07876c681be04c6a8541d992d6db58c7 Critique for group:
Rohit- Positives: -I like how in-depth you went in your explanations of the input/out, binary, and boolean expressions. I also think that your in-depth explanations show your understanding of the code and what you programmed. -Your connection of the PBL to the CBL was excellent as you showed how the two related to one another and referenced specifically what section(1.2) in CB inputs and outputs were referenced in. -Your part where you showed the code that allows for overflow was a good touch because its important to recognize that sometimes a number that is larger than what can be stored is given, and we need to figure out what to do with it.
Improvement: I think for the first part of the video you, should have shown a little bit of the code behind the colors game just to show the code and explain a little behind it. For that reason, I gave a -0.25. Score: 5.75/6
Aadit - Positives:
-I think that the way that you implemented firebase to add in emails and passwords to create logins showed a very high understanding of the code -I think that it was good how much code and behind the scenes, you showed, and how much runtime you showed. The balance between the two was good as it helped us gain a better understanding of the topic. -For the API, I think your code and explanation of a lazy programmer was good because it showed how iteration is helpful in coding and makes things overall more efficient. Improvement: I think you could have shown a little more connection to college board topics, but your code was still very in-depth and showed a lot of understanding. For that reason, I gave -0.25. Score: 5.75/6
Rohan - Positives: -Your explanation of collaboration and scrum board showed how we all work together as a team, which was a really big part of college board and how they want us to work together -I can see that you put in a lot of effort into making sure that this week you tried to do a lot more coding, and also worked a lot on making the website look better with the wireframes and other aspects of the homepage. -Your work with the dictionaries was in-depth and showed understanding of how they work and how we can use them and implement them into our project(especially the math section)
Improvement: I think it would have been a little better to show a little bit more code so we could understand what was going on behind the scenes, but other than that it was good. For that I took off -0.25 Score: 5.75/6
Rohan's video Critique for group:
Rohit- Positives:
-Good citation to Collegeboard weeks -Liked the connection to the mini-labs to the color codes -Great explanation for each topic!
Improvement: -Show a little bit more of the backend code in the beginning Score: 5.75/6
Aadit - Positives: -Gave good background for each topic -Complex coding done for firebase -Interactive and shows change throughout the project
Improvements: -connect to collegeboard a little more Score: 5.75/6
Adi- Positives:
-I like how you showed specifically how everything connects to Collegeboard -I like how you also implemented the runtime along with the code -Looks like he spent a lot more time working the specifics of the code and the effort was definitely there
Improvement: -Add a little more coding for iteration Score: 5.75/6 Good work!
Contributor | GitHub | Video Link | Avg Score |
---|---|---|---|
Aadit Gupta | @aaditgupta21 | Video Link | Score: 5.75 |
Adi Khandelwal | @Adi-K-Coding | Video Link | Score: 5.75 |
Rohit De | @rohitd3 | Video Link | Score: 5.75 |
Rohan Gaikwad | @rohang326 | Video Link | Score: 5.75 |
Critique for group:
Adi
Improvements
Rohit
Improvements
Rohan
Improvements
Grading by Leah: 3/3 for everyone, notes, quizzes, and everything is there