aadl / arborcat

Drupal 8 module providing catalog interface for Evergreen
GNU General Public License v3.0
3 stars 0 forks source link

better 404 result for catalog items no longer in couch? #73

Open elitrichous opened 6 years ago

elitrichous commented 6 years ago

Some users have items in their wishlist that are not a part of the new site. cf.

http://old.aadl.org/catalog/record/1257124

this returns 404 on the new site:

https://aadl.org/catalog/record/1257124

Looking at this item it seems appropriate it's not in couch, but we need to handle this situation more transparently.

eby commented 6 years ago

Everything is still in couch. This record is at it original bnum since there wasn't an evg version.

The reason it is nginx 404 is that we are redirecting all the old bnums to their new one. It ends with a simple 404 as that was least overhead. I might be able to build a view to get all the suppressed items that no longer exist but not sure it is worth the overhead.

I can end the redirect file with a redirect to something else for long gone bibs, we just need to make the page. Not sure if https://aadl.org/404 is enough?

eby commented 6 years ago

To be clear this should really only be the case of long long gone bibs that were actually deleted from iii. Things that were suppressed in iii and brought over should all have their new evg numbers.