aadl / arborelastic

Custom Elasticsearch module for Drupal 8
1 stars 0 forks source link

log1p and regex fix #37

Closed mswinehart closed 7 months ago

mswinehart commented 7 months ago

Other than placing AADL items on an even popularity modifier as overdrive records, these changes are functional bugfixes only and don't affect rankings. They fix errors where queries returned empty when they shouldn't.

  1. I neglected to include A-Z in the queryable regex, so queries like author:"zadie smith" would work, but queries like author:Zadie Smith wouldn't.

  2. When the overdrive exception was added, I didn't account for the broken pattern in the queryable. Adding the raw value without its key prevents the fallback query from being triggered with a key. That fallback query would result in some author queries that weren't precisely formatted to return nothing when they ought to, because the whole string "author:{whatever}" was being included as a multimatch.

  3. Finally, the overdrive missing parameter is changed to 0 so that they don't have an edge over AADL items with no hold history anymore.