aadnk / ProtocolLib

Provides read and write access to the Minecraft protocol with Bukkit.
GNU General Public License v2.0
287 stars 92 forks source link

Fixed protocol injection with latest netty on minecraft 1.11 and below #175

Closed lukalt closed 3 years ago

lukalt commented 4 years ago

Injection is forced to be delayed since Minecraft 1.12+. This has been hotfixed in https://github.com/dmulloy2/ProtocolLib/commit/b4f9c501b3dd33ff740b917c6ba83cfb99977e61.

Unfortunately, I still need to stick to spigot 1.8.8. We currently try to update to Java 14, which is not supported by spigot 1.8.8 because the netty version is incompatible. After updating the bundled Netty version to 4.1.49 (yeah, I know it's hacky af), I realized that ProtocolLib was not working anymore ("Unable to find NetworkManager in .."). Thus, I added a delay of the injection if a newer Netty version is present.

ghost commented 3 years ago

Close this, already added