search

aadnk / ProtocolLib

Provides read and write access to the Minecraft protocol with Bukkit.
GNU General Public License v2.0
288 stars 92 forks source link

ConcurrentModificationException Kicks Player without Stack Trace #176

Closed Kneesnap closed 2 years ago

Kneesnap commented 4 years ago

Describe the bug This issue is a duplicate of #96 Unfortunately, this is a rather difficult bug to provide information for. Every so often, a player on my server will get kicked. In the console, this message is present, examples seen below.

Unfortunately, this is difficult because there is no other information besides a CME occurred. One of them has a ViaVersion warning, however I have no evidence that this is related, especially since most of the time there is no ViaVersion message.

Expected behavior I expect a stack-trace to be printed, so it's possible to pin-point where the issue is coming from-- we have a lot of packet listeners and many of them we cannot disable without issue. We don't even know if it's from any of our code or if it's from another plugin, we have a bunch which all use ProtocolLib. On the off-chance this message is coming from ViaVersion, then this is not an issue with ProtocolLib (probably), but I think it remains to be shown if that is true.

Screenshots image

image

Version Info https://pastebin.com/J691UpBL

MiniDigger commented 4 years ago

start by updating protocollib to 4.5.1

Kneesnap commented 4 years ago

Will do. I'll post an update next time it happens, it might be a little while before I can conclusively say if that makes the issue go away.

On Tue, May 26, 2020, 1:29 AM MiniDigger notifications@github.com wrote:

start by updating protocollib to 4.5.1

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/aadnk/ProtocolLib/issues/176#issuecomment-633885568, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSCIYIT53DH7SWQ2ZRX5GLRTN4XNANCNFSM4NJ3JTHQ .

EDIT: I just got around to updating it today (6/4). I'll monitor everything and watch what happens.

Kneesnap commented 2 years ago

Forgot to update this. The CME was occurring in vanilla packet writing logic.