search

aadnk / ProtocolLib

Provides read and write access to the Minecraft protocol with Bukkit.
GNU General Public License v2.0
288 stars 92 forks source link

[1.19.2] Error when sending PacketPlayOutEntityEffect using Wrapper #203

Closed alexxbout closed 1 year ago

alexxbout commented 1 year ago

This issue is not solved in a development build

Describe the bug A crash of the client just after sending packet.

[15:47:44] [Netty Server IO #2/ERROR]: Error receiving packet 105 java.lang.IllegalArgumentException: Can't find id for 'null' in map Registry[ResourceKey[minecraft:root / minecraft:mob_effect] (Experimental)] at net.minecraft.network.PacketDataSerializer.a(PacketDataSerializer.java:138) ~[spigot-1.19.2-R0.1-SNAPSHOT.jar:3608-Spigot-6198b5a-b5aa0be] at net.minecraft.network.protocol.game.PacketPlayOutEntityEffect.a(SourceFile:61) ~[spigot-1.19.2-R0.1-SNAPSHOT.jar:3608-Spigot-6198b5a-b5aa0be] at net.minecraft.network.PacketEncoder.a(SourceFile:45) ~[spigot-1.19.2-R0.1-SNAPSHOT.jar:3608-Spigot-6198b5a-b5aa0be] at net.minecraft.network.PacketEncoder.encode(SourceFile:14) ~[spigot-1.19.2-R0.1-SNAPSHOT.jar:3608-Spigot-6198b5a-b5aa0be] at io.netty.handler.codec.MessageToByteEncoder.write(MessageToByteEncoder.java:107) ~[netty-codec-4.1.77.Final.jar:4.1.77.Final] at io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(AbstractChannelHandlerContext.java:717) ~[netty-transport-4.1.77.Final.jar:4.1.77.Final] at io.netty.channel.AbstractChannelHandlerContext.invokeWrite(AbstractChannelHandlerContext.java:709) ~[netty-transport-4.1.77.Final.jar:4.1.77.Final] at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:792) ~[netty-transport-4.1.77.Final.jar:4.1.77.Final] at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:702) ~[netty-transport-4.1.77.Final.jar:4.1.77.Final] at io.netty.handler.codec.MessageToByteEncoder.write(MessageToByteEncoder.java:120) ~[netty-codec-4.1.77.Final.jar:4.1.77.Final] at io.netty.channel.AbstractChannelHandlerContext.invokeWrite0(AbstractChannelHandlerContext.java:717) ~[netty-transport-4.1.77.Final.jar:4.1.77.Final] at io.netty.channel.AbstractChannelHandlerContext.invokeWriteAndFlush(AbstractChannelHandlerContext.java:764) ~[netty-transport-4.1.77.Final.jar:4.1.77.Final] at io.netty.channel.AbstractChannelHandlerContext.write(AbstractChannelHandlerContext.java:790) ~[netty-transport-4.1.77.Final.jar:4.1.77.Final] at io.netty.channel.AbstractChannelHandlerContext.writeAndFlush(AbstractChannelHandlerContext.java:758) ~[netty-transport-4.1.77.Final.jar:4.1.77.Final] at io.netty.channel.DefaultChannelPipeline.writeAndFlush(DefaultChannelPipeline.java:1020) ~[netty-transport-4.1.77.Final.jar:4.1.77.Final] at io.netty.channel.AbstractChannel.writeAndFlush(AbstractChannel.java:311) ~[netty-transport-4.1.77.Final.jar:4.1.77.Final] at com.comphenix.protocol.injector.netty.channel.NettyChannelProxy.writeAndFlush(NettyChannelProxy.java:227) ~[?:?] at com.comphenix.protocol.injector.netty.channel.NettyChannelProxy.writeAndFlush(NettyChannelProxy.java:233) ~[?:?] at net.minecraft.network.NetworkManager.a(NetworkManager.java:224) ~[spigot-1.19.2-R0.1-SNAPSHOT.jar:3608-Spigot-6198b5a-b5aa0be] at net.minecraft.network.NetworkManager.lambda$7(NetworkManager.java:213) ~[spigot-1.19.2-R0.1-SNAPSHOT.jar:3608-Spigot-6198b5a-b5aa0be] at com.comphenix.protocol.injector.netty.channel.NettyEventLoopProxy.lambda$proxyRunnable$2(NettyEventLoopProxy.java:48) ~[?:?] at io.netty.util.concurrent.AbstractEventExecutor.runTask(AbstractEventExecutor.java:174) [netty-common-4.1.77.Final.jar:4.1.77.Final] at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:167) [netty-common-4.1.77.Final.jar:4.1.77.Final] at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:470) [netty-common-4.1.77.Final.jar:4.1.77.Final] at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:503) [netty-transport-4.1.77.Final.jar:4.1.77.Final] at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:995) [netty-common-4.1.77.Final.jar:4.1.77.Final] at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) [netty-common-4.1.77.Final.jar:4.1.77.Final] at java.lang.Thread.run(Thread.java:833) [?:?] [15:47:44] [Server thread/INFO]: iCrossing lost connection: Internal Exception: io.netty.handler.codec.EncoderException: java.lang.IllegalArgumentException: Can't find id for 'null' in map Registry[ResourceKey[minecraft:root / minecraft:mob_effect] (Experimental)]

To Reproduce Steps to reproduce the behavior: Send a PacketPlayOutEntityEffect to the player.

Expected behavior Potion effect to be sent.

Screenshots image image image

Version Info ProtocolLib Dump Timestamp: 12/17/22 15:49:52

ProtocolLib Version: ProtocolLib v5.0.0-SNAPSHOT-b604 Bukkit Version: 1.19.2-R0.1-SNAPSHOT Server Version: 3608-Spigot-6198b5a-b5aa0be (MC: 1.19.2) Java Version: 18.0.2.1

ProtocolLib: com.comphenix.protocol.ProtocolLib@15748a55[ statistics=com.comphenix.protocol.metrics.Statistics@12cf2cf0 packetTask=2 tickCounter=2951 configExpectedMod=1 updater=com.comphenix.protocol.updater.SpigotUpdater@77c812e3 redirectHandler=com.comphenix.protocol.ProtocolLib$2@7db1aba2 commandProtocol=com.comphenix.protocol.CommandProtocol@4c26b063 commandPacket=com.comphenix.protocol.CommandPacket@27e5bdbb commandFilter=com.comphenix.protocol.CommandFilter@100decae packetLogging=com.comphenix.protocol.PacketLogging@6091a9b6 skipDisable=false isEnabled=true loader=org.bukkit.plugin.java.JavaPluginLoader@194db86f server=CraftServer{serverName=CraftBukkit,serverVersion=3608-Spigot-6198b5a-b5aa0be,minecraftVersion=1.19.2} file=plugins/ProtocolLib.jar description=org.bukkit.plugin.PluginDescriptionFile@6cd820c3 dataFolder=plugins/ProtocolLib classLoader=org.bukkit.plugin.java.PluginClassLoader@64d826a5 naggable=true newConfig=YamlConfiguration[path='', root='YamlConfiguration'] configFile=plugins/ProtocolLib/config.yml logger=org.bukkit.plugin.PluginLogger@7513a675 ] Manager: com.comphenix.protocol.injector.PacketFilterManager@1885c549[ plugin=ProtocolLib v5.0.0-SNAPSHOT-b604 server=CraftServer{serverName=CraftBukkit,serverVersion=3608-Spigot-6198b5a-b5aa0be,minecraftVersion=1.19.2} reporter=com.comphenix.protocol.ProtocolLib$1@35f620a2 minecraftVersion=(MC: 1.19.2) asyncFilterManager=com.comphenix.protocol.async.AsyncFilterManager@7b9648bb pluginVerifier=com.comphenix.protocol.injector.PluginVerifier@13de79b2 inboundListeners=com.comphenix.protocol.injector.SortedPacketListenerList@2547490d outboundListeners=com.comphenix.protocol.injector.SortedPacketListenerList@21b09e37 registeredListeners=[] packetInjector=com.comphenix.protocol.injector.netty.manager.NetworkManagerPacketInjector@682ac92a playerInjectionHandler=com.comphenix.protocol.injector.netty.manager.NetworkManagerPlayerInjector@8592e74 networkManagerInjector=com.comphenix.protocol.injector.netty.manager.NetworkManagerInjector@17c91153 debug=false closed=false injected=true ]

No listeners

Additional context I have tried dev build 604-605-607.