removed some design smells

aadnk / ProtocolLib

Provides read and write access to the Minecraft protocol with Bukkit.

GNU General Public License v2.0

288 stars 92 forks source link

removed some design smells #209

Open 8ngine opened 1 year ago

8ngine commented 1 year ago

merging different types of smells

MiniDigger commented 1 year ago

? you only added unused code. the utils seem nice, tinyprotocol is used as a one class copy paste thing tho, so if you indent on exposing this as new api it should prolly be inlined

mr583372 commented 1 year ago

no, I had been removing code smells for a university assignment though I'm not great with Github / Gitlab yet so I clearly made several mistakes both in my work and the upload I'm sorry for the inconvenience.