Fix for charset issue when getting data from TXXX frame. - Githubissues

aadsm / jsmediatags

Media Tags Reader (ID3, MP4, FLAC)

Other

758 stars 127 forks source link

Fix for charset issue when getting data from TXXX frame. #120

Closed curtismenmuir closed 5 years ago

curtismenmuir commented 5 years ago

userDefinedData was being returned still encoded (E.G. "data":{"user_description":"LICENCE TYPE","data":"ÿþO"}}
Added missing charset into getStringWithCharsetAt() function
Test updates

aadsm commented 5 years ago

Thank you so much for looking into this and putting this up! I’ll take a look over the weekend.

curtismenmuir commented 5 years ago

@aadsm sorry I was supposed to go back and fix this. Thanks for taking the time to review this! :) I have pushed update to fix this indentation

curtismenmuir commented 5 years ago

@aadsm is the formatting ok now for getting this merged?

curtismenmuir commented 5 years ago

@aadsm thanks for reviewing. No worries about taking some time! :) I have removed package-lock.json updates and I have fixed the formatting in the tests!

curtismenmuir commented 5 years ago

@aadsm do those updates look ok now?

curtismenmuir commented 5 years ago

@aadsm thanks for merging this :) When are you planning on releasing a new version with the fix? I have a release coming at the end of the month for a project I am working on and it would be great to have the fix included.

aadsm commented 5 years ago

@curtismenmuir no problem, I'll do that over the weekend.

curtismenmuir commented 5 years ago

@aadsm that would be perfect, thank you so much!

aadsm commented 5 years ago

@curtismenmuir fyi: I've just published a new version with your fixes :) I also added you to the contributors list: https://github.com/aadsm/jsmediatags/blob/master/CONTRIBUTORS.md#bugs.