Share ChunkedFileData via @tokenizer/range dependency

aadsm / jsmediatags

Media Tags Reader (ID3, MP4, FLAC)

Other

752 stars 128 forks source link

Share ChunkedFileData via @tokenizer/range dependency #135

Closed Borewit closed 3 years ago

Borewit commented 4 years ago

This is a proposal to share ChunkedFileData in the same dependency @tokenizer/range between jsmediatags, tokenizer-http, @tokenizer/s3 and maybe others in the future.

These micro modules seamlessly integrate with the strtok3 which is used by file-type & music-metadata.

The class ChunkedFileData is originating from jsmedatags.

I changed the type chunk.data from ArrayBuffer to Uint8Array for more flexibility.

aadsm commented 3 years ago

(It seems that I've stopped getting PR mails from this repo, so sorry for only looking into this now)

I really appreciate the effort you did so my project could also reuse that package, but to be honest, I really prefer to not add any more dependencies, so I can control as much as I can the package size.