search

aadsm / jsmediatags

Media Tags Reader (ID3, MP4, FLAC)
Other
748 stars 128 forks source link

User defined URL link/text frames incorrectly parsed #38

Closed jhaber1 closed 7 years ago

jhaber1 commented 7 years ago

User defined URL link frames are being incorrectly parsed. Code is assuming that the frame description value is the frame value, but the actual URL is actually right after the description. Results in output e.g.:

{
...
WXXX: { 
  id: 'WXXX',
  size: 83,
  description: 'User defined URL link frame',
  data: 'Description of the user defined link frame'
},
...
}

Haven't verified it, but am also positive that the same is happening for user defined text frames given that the code is very similar.

aadsm commented 7 years ago

Yeah, nice find. I don't have time right now to do this, the code is here: https://github.com/aadsm/jsmediatags/blob/master/src/ID3v2FrameReader.js#L130-L146 Do you want to try a PR for this?

aadsm commented 7 years ago

This has been fixed now, thank you for your PR!