aadsm / jsmediatags

Media Tags Reader (ID3, MP4, FLAC)
Other
748 stars 128 forks source link

Disk number (iTunes .m4a) #55

Closed icidasset closed 7 years ago

icidasset commented 7 years ago

Hey António,

I was wondering whether you knew what the problem here could be. I'm trying to read the disc number from a iTunes m4a file.

I'm getting the following result:

disk: {
  data: 0,
  description: "Disc Number",
  id: "disk",
  size: 30
}

But I expect data to be 2 instead of 0. The correct data looks like this (bottom left):

screen shot 2017-05-21 at 9 54 30 pm

You can find the file here: http://ongaku-ryoho-test.s3.amazonaws.com/2-01-best_foot_forward_(alternate_version).m4a

Thanks! 🥇

PS. Please add a donate button to the readme 💰

aadsm commented 7 years ago

I've just published a new version with the fix for reading the Disc tag, thanks for reporting this bug! For donation, I would prefer if the money was redirected towards the "Girls Who Code" NPO: https://www.classy.org/checkout/donation?eid=77372.

icidasset commented 7 years ago

@aadsm Done 😄

Thanks again! 🥇 🙏

aadsm commented 7 years ago

Cool! Would you like me to add you as contributor? I'm planning to list donation contributors with $ amount they donated, if they wish so.

On Tue, May 30, 2017 at 03:52 Steven Vandevelde notifications@github.com wrote:

@aadsm https://github.com/aadsm Done 😄

Thanks again! 🥇 🙏

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/aadsm/jsmediatags/issues/55#issuecomment-304842973, or mute the thread https://github.com/notifications/unsubscribe-auth/AAExKpn7HXvWb6zWK2M1f0VFU7hLSRC0ks5r-_TagaJpZM4NhtOW .

-- Best regards, António Afonso

icidasset commented 7 years ago

Sure 😄