aadsm / jsmediatags

Media Tags Reader (ID3, MP4, FLAC)
Other
748 stars 128 forks source link

Add Tag Reader for FLAC Files #71

Closed ttpcodes closed 7 years ago

ttpcodes commented 7 years ago

I noticed issue #25 which seems to have been untouched since May 31st, 2016. I figured that since I wanted support for FLAC files anyway, that I would draft this up as a makeshift solution for retrieving tags from FLAC files.

I've left the jsmediatags.js file intact as there are still a few issues with the implementation I wrote up:

Hopefully these can be resolved in future commits.

The specification for the FLAC and Ogg Vorbis formats can be found here and here. As the two formats are very similar, a small rewrite should be all that's needed to address #25.

Expectations (will be marked off once unit tests are written):

ttpcodes commented 7 years ago

In addition to the changes I've made, I've also added a brief checklist of what I want to test and implement before declaring this as complete. If there's anything else you'd like, just let me know.

aadsm commented 7 years ago

@TehTotalPwnage, have you thought about applying for an internship as a frontend engineer? https://www.facebook.com/careers/jobs/a0I1200000LTGJBEA5/

aadsm commented 7 years ago

Thanks!!