search

aadsm / node-id3

Get music metadata from buffers and files.
Other
74 stars 86 forks source link

Possible copyright infringement #3

Closed aadsm closed 11 years ago

aadsm commented 11 years ago

[Since my original issue was closed and github issues were removed from the original project I repost this open issue here, this fork only exists as proof of the following statements]

I've noticed the huge similarities between your library and my JavaScript ID3 Reader library (https://github.com/aadsm/JavaScript-ID3-Reader). In fact they are so similar that it leads me to believe that node-id3 is a copy of my repository with some name changes and no reference to the authors at all.

Take these two functions as examples: readFrames:
Mine: https://github.com/aadsm/JavaScript-ID3-Reader/blob/master/src/id3v2.js : Yours: https://github.com/Tim-Smart/node-id3/blob/master/lib/id3/id3v2.js

readUTF16String (this one even has the exact same variable names):
Mine: https://github.com/aadsm/JavaScript-ID3-Reader/blob/master/src/stringutils.js : Yours: https://github.com/Tim-Smart/node-id3/blob/master/lib/id3/common.js

Another piece of evidence:

My shorcuts structure: var _shortcuts = { "title" : ["TIT2", "TT2"], "artist" : ["TPE1", "TP1"], "album" : ["TALB", "TAL"], "year" : ["TYER", "TYE"], "comment" : ["COMM", "COM"], "track" : ["TRCK", "TRK"], "genre" : ["TCON", "TCO"], "picture" : ["APIC", "PIC"], "lyrics" : ["USLT", "ULT"] };

Yours: var ID3v2_ALIAS = exports.ID3v2_ALIAS = { "title" : ["TIT2", "TT2"], "artist" : ["TPE1", "TP1"], "album" : ["TALB", "TAL"], "year" : ["TYER", "TYE"], "comment": ["COMM", "COM"], "track" : ["TRCK", "TRK"], "genre" : ["TCON", "TCO"], "picture": ["APIC", "PIC"], "lyrics" : ["USLT", "ULT"] };

If you did in fact based your work on the JavaScript ID3 Reader library, please be reminded that it is (some parts of it) copyrighted by Opera Software ASA, under the MIT/BSD license and it requires proper attribution to the authors.

Thank you.

aadsm commented 11 years ago

It seems that there were some changes 9 months ago when the original issue was closed. I'm not really sure what the intention is/was as there was no comment on my issue. My fork doesn't mention tim-smart's original repository anymore, and his repository now states that is a fork of mine. My guess is that the original repository was closed (?) and a new one created out of my fork.

I'll take this as a (even though silent) copyright / original authors recognition and will add a copyright file.

aadsm commented 11 years ago

I've added a LICENSE.md file explaining the derivative work and original authors and consider this issue fixed.