search

aae-stats / aae.data

Methods to perform QA/QC on AAE data
Other
1 stars 0 forks source link

Error is thrown if there are no lengths recorded in the data. #13

Closed adriankitch closed 1 year ago

adriankitch commented 1 year ago

Error is thrown if there are no lengths recorded in the data.

Quitting from lines 170-231 [measurement-check] (qaqc.Rmd) Error incombine_vars()`: ! Faceting variables must have at least one value Backtrace:

  1. base::print(p)
  2. ggplot2:::print.ggplot(p)
  3. ggplot2:::ggplot_build.ggplot(x)
  4. layout$setup(data, plot$data, plot$plot_env)
  5. ggplot2 (local) setup(..., self = self)
  6. self$facet$compute_layout(data, self$facet_params)
  7. ggplot2 (local) compute_layout(..., self = self)
  8. ggplot2::combine_vars(data, params$plot_env, vars, drop = params$drop)`
jdyen commented 1 year ago

Didn't we update this in the latest version? (#12)

adriankitch commented 1 year ago

I don't think so. This is from Frank and I got him to update to the latest version. He doesn't have any length data so the LW charts seem to fall over. The previous fix was for no fork lengths.

jdyen commented 1 year ago

Should all be the same fix (fork lengths, weights, and total lengths). Can you get Frank to send me the data and I'll have a look? I'm suspicious given the error is identical to the previous error.

jdyen commented 1 year ago

Fixed in cac4d8a