search

aaemnnosttv / wp-cli-login-command

Log in to WordPress with secure passwordless magic links.
https://aaemnnost.tv/wp-cli-commands/login/
MIT License
298 stars 47 forks source link

Add support for url prefix #77

Open oxyc opened 1 month ago

oxyc commented 1 month ago

See https://github.com/aaemnnosttv/wp-cli-login-command/issues/10#issuecomment-2260821596 Just opening this up for discussion but this might not be the best way since at a glance you might expect the prefix to be validated which it's not. Any thoughts or not looking to add support for this?

aaemnnosttv commented 3 weeks ago

Hey, thanks for the PR. This looks like a safe change to make which is also backwards compatible. Is there a reason why it would be preferable to add this with a filter rather than an an argument to the command?

oxyc commented 3 weeks ago

Not at all, a command line flag would work just as well. I changed the PR.

Note, I didn't run the tests (yet) as I didn't have a local environment set up for behat.