search

aaemnnosttv / wp-cli-login-command

Log in to WordPress with secure passwordless magic links.
https://aaemnnost.tv/wp-cli-commands/login/
MIT License
294 stars 47 forks source link

Configurable timeout for magic link ? #9

Closed niladam closed 7 years ago

niladam commented 7 years ago

I think it would be great to have the means to be able to configure the magic link timeout. Maybe via wp-cli.yml or via a command attribute ?

niladam commented 7 years ago

I opened pull request #12 that tackles this, using environment variable WP_CLI_LOGIN_TIMEOUT_DURATION as means to control the timeout link.

aaemnnosttv commented 7 years ago

Thanks for the suggestion, this is something I have thought about adding as well and I think it's definitely a reasonable request.

Thanks for the pull request too I will review that in just a minute and follow up with you there :)

niladam commented 7 years ago

You're most welcome. Initially i thought about going about reading the value from a global/local wp-cli.yml but when i was working on it i thought ENV would be easier to work with as you can always export WP_CLI_LOGIN_TIMEOUT_DURATION=10 for example before running the command. Also, people could want this to be server-agnostic so it makes sense to have it like that..