search

aaemnnosttv / wp-cli-valet-command

Harness the power of Laravel Valet for creating fully functional WordPress installs in seconds.
https://aaemnnost.tv/wp-cli-commands/valet/
299 stars 31 forks source link

Clarification on need to register site with Valet #57

Closed jasperf closed 1 year ago

jasperf commented 5 years ago

See https://github.com/aaemnnosttv/wp-cli-valet-command/issues/15 where we ran into 404 issues due to not having done a valet park in the directory the installation was done nor a valet link.

aaemnnosttv commented 5 years ago

Thanks for the pull request! Unfortunately, I cannot accept it as-is as the README is generated dynamically from the code; this would result in your changes being lost on the next generation.

The corresponding portion of the codebase you're looking to change is right here: https://github.com/aaemnnosttv/wp-cli-valet-command/blob/783a3a7707d8e2cc519b0fba63fd5ae784a6a1ed/src/ValetCommand.php#L64-L66

Also, what does NB stand for?

jasperf commented 5 years ago

NB - Nota Bene - a Latin phrase (or its abbreviation) used to indicate that special attention should be paid to something.

Will see if I can move it al then @aaemnnosttv .

aaemnnosttv commented 5 years ago

Thanks! To regenerate the readme, you can run composer install and then composer update-readme to include this with your PR. If not I can add it for you.

jasperf commented 5 years ago

Did composer install and that went well. Then I did

wp-cli-valet-command @ MacMini [jasper] $ composer update-readme
> wp scaffold package-readme . --force
Warning: File already exists
./README.md
Replacing

Success: Created package readme.
wp-cli-valet-command @ MacMini [jasper] $ git status
On branch master
Your branch is up to date with 'origin/master'.

So it replaced.. but did not..?

NuclearMonster commented 4 years ago

this issue is still present and the readme still needs to be updated with the 404, I was lucky to find #15 in the closed issues