Fix broken tests and compatibility with PHP 8 - Githubissues

aaemnnosttv / wp-cli-valet-command

Harness the power of Laravel Valet for creating fully functional WordPress installs in seconds.

https://aaemnnost.tv/wp-cli-commands/valet/

299 stars 31 forks source link

Fix broken tests and compatibility with PHP 8 #77

Closed aaemnnosttv closed 3 years ago

aaemnnosttv commented 3 years ago

Tests started failing after changes were introduced to wp-cli-tests which broke a temporary workaround that was in place.

See https://github.com/wp-cli/wp-cli-tests/pull/127

This PR also updates the version constraint for illuminate/container to support newer versions. It was previously locked to a specific 5.x range due to inclusion of illuminate/support in later versions, but this was since removed in https://github.com/laravel/framework/pull/30518 (https://github.com/illuminate/container/releases/tag/v6.5.1).

aaemnnosttv commented 3 years ago

Tests are failing here due to wp-sqlite-db compatibility with PHP 8.