search

aaemnnosttv / wp-sqlite-db

A single file drop-in for using a SQLite database with WordPress. Based on the original SQLite Integration plugin.
561 stars 94 forks source link

php v8 (via docker `php:fpm-alpine`) failing #17

Closed traceypooh closed 2 years ago

traceypooh commented 3 years ago

any chance of a fix?

eg:

2021/02/28 21:37:52 [error] 13#13: *3 FastCGI sent in stderr: "PHP message: PHP Fatal error:  Declaration of WP_SQLite_DB\PDOEngine::query($statement, $mode = PDO::ATTR_DEFAULT_FETCH_MODE, $arg3 = null, array $ctorargs = []) must be compatible with PDO::query(string $query, ?int $fetchMode = null, mixed ...$fetchModeArgs) in /usr/share/nginx/html/wp-content/db.php on line 1336" while reading response header from upstream, client: 127.0.0.1, server: _, request: "GET / HTTP/1.1", upstream: "fastcgi://127.0.0.1:9000", host: "localhost:5000"
aaemnnosttv commented 3 years ago

Yes, should be able to fix it soonish. Would be open to merging a PR as well if someone else can get to it before me though 👍

peterjanes commented 3 years ago

Looks like #16 may be sufficient?

kk6mrp commented 3 years ago

Is this working now for you since https://github.com/aaemnnosttv/wp-sqlite-db/pull/21/?

aaemnnosttv commented 3 years ago

Should work now @kk6mrp , can anyone confirm?

kk6mrp commented 2 years ago

@aaemnnosttv I'm using PHP 8 on Alpine Linux and do not get this error. Should be good to close the issue.

aaemnnosttv commented 2 years ago

Thanks @kk6mrp, we can always reopen if needed 👍