search

aagarwal1012 / Animated-Text-Kit

🔔 A flutter package to create cool and beautiful text animations. [Flutter Favorite Package]
https://animated-text-kit.web.app
MIT License
1.66k stars 304 forks source link

added customisable fade in and fade out timings #203

Closed ritvij14 closed 3 years ago

ritvij14 commented 3 years ago

Pull Request Process

  1. Ensure any install or build dependencies are removed before the end of the layer when doing a build.
  2. Update the README.md if needed with details of changes to the interface, this includes new environment variables, exposed ports, useful file locations and container parameters.
  3. Increase the version numbers in any examples files and the README.md to the new version that this Pull Request would represent. The versioning scheme we use is SemVer.
  4. You may merge the Pull Request in once you have the sign-off of one developer, or if you do not have permission to do that, you may request the second reviewer to merge it for you.

Issues:

Fixes #190

Description:

ritvij14 commented 3 years ago

Please review the feedback. Please confirm if you are a GSSOC participant.

@awhitford yes I am a GSSOC participant. Do I have to send a screenshot of my selection email?

awhitford commented 3 years ago

@awhitford yes I am a GSSOC participant. Do I have to send a screenshot of my selection email?

Great. I just want to ensure that we track this for GSSOC21 so that you can get your points. I'm not 100% sure what we need beyond a level designation, and I'm waiting on the documentation/guide for that (should be later today).

codecov[bot] commented 3 years ago

Codecov Report

Merging #203 (39d10c3) into master (8dc81cd) will increase coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
+ Coverage   95.05%   95.09%   +0.03%     
==========================================
  Files           9        9              
  Lines         425      428       +3     
==========================================
+ Hits          404      407       +3     
  Misses         21       21
Impacted Files Coverage Δ
lib/src/fade.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8dc81cd...39d10c3. Read the comment docs.

ritvij14 commented 3 years ago

@awhitford I have made all the modifications you ask, please have a look.

awhitford commented 3 years ago

@aagarwal1012 & team: Do you have any testing requirements for a change like this? (The lines are being covered, but there is not a new, unique test case for adjusting these new parameters. Does there need to be?)

awhitford commented 3 years ago

@aagarwal1012 It looks like both stable and beta builds are required. Is that on purpose? (I thought only stable should be required now.)

aagarwal1012 commented 3 years ago

It looks like both stable and beta builds are required. Is that on purpose? (I thought only stable should be required now.)

@awhitford, many flutter developers use the beta channel, which's why I made the beta build mandatory to pass.

aagarwal1012 commented 3 years ago

@aagarwal1012 & team: Do you have any testing requirements for a change like this? (The lines are being covered, but there is not a new, unique test case for adjusting these new parameters. Does there need to be?)

Yes, I agree with you -- we should add parameter specific tests, we can create a separate GitHub issue for the same.

aagarwal1012 commented 3 years ago

@allcontributors add @ritvij14 for code.

allcontributors[bot] commented 3 years ago

@aagarwal1012

I've put up a pull request to add @ritvij14! :tada: