search

aagarwal1012 / Animated-Text-Kit

🔔 A flutter package to create cool and beautiful text animations. [Flutter Favorite Package]
https://animated-text-kit.web.app
MIT License
1.66k stars 304 forks source link

Remove `DefaultTextStyle` as parent in `README.md` and `example` #221

Open SirusCodes opened 3 years ago

SirusCodes commented 3 years ago

I would suggest to remove use of DefaultTextStyle in README.md and example which was introduced in #217 as it would suggest the user to use it for every time when they want to change the text style

awhitford commented 3 years ago

Using DefaultTextStyle avoids having to repeat having to specify the textStyle for each AnimatedText instance. It cut a lot of lines of code in the sample code.

Having said that, I support the idea of a section that explains the benefits of using DefaultTextStyle.

awhitford commented 3 years ago

... which was introduced in #221 as it would suggest the user to use it for every time when they want to change the text style.

@SirusCodes I think you meant to reference #217.

SirusCodes commented 3 years ago

Using DefaultTextStyle avoids having to repeat having to specify the textStyle for each AnimatedText instance. It cut a lot of lines of code in the sample code.

Having said that, I support the idea of a section that explains the benefits of using DefaultTextStyle.

Yes because if I'm a beginner in Flutter and say this in a package I would think that this is the only way to use this package...

I think we can add a section explaining the use of DefaultTextStyle and in our example use it somewhere where we have repetation not in all animation?

Nidhi-2000 commented 3 years ago

Hey , @SirusCodes can you please assign this issue to me . I am a GSSOC'21 participant

Nidhi-2000 commented 3 years ago

thanks @Siruscodes.

harshita2319 commented 3 years ago

I'd like to work on this (GSSOC participant)

SirusCodes commented 3 years ago

@harshita2319 go ahead.

harshita2319 commented 3 years ago

@harshita2319 go ahead.

Should I add new file for explaining the use as you've mentioned earlier?

SirusCodes commented 3 years ago

Just update the README @harshita2319