aagarwal1012 / Animated-Text-Kit

πŸ”” A flutter package to create cool and beautiful text animations. [Flutter Favorite Package]
https://animated-text-kit.web.app
MIT License
1.66k stars 304 forks source link

[feat] Prepare animated text kit flutter web app for demo #222

Closed aagarwal1012 closed 3 years ago

aagarwal1012 commented 3 years ago

Tickets

Description

Reference

This tweet has a gist that shows how to publish a flutter web build to Firebase Hosting Preview Channels.

codecov[bot] commented 3 years ago

Codecov Report

Merging #222 (bfe0fe0) into master (990d99a) will not change coverage. The diff coverage is n/a.

:exclamation: Current head bfe0fe0 differs from pull request most recent head ac89d69. Consider uploading reports for the commit ac89d69 to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##           master     #222   +/-   ##
=======================================
  Coverage   95.09%   95.09%           
=======================================
  Files           9        9           
  Lines         428      428           
=======================================
  Hits          407      407           
  Misses         21       21           

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 990d99a...ac89d69. Read the comment docs.

github-actions[bot] commented 3 years ago

Visit the preview URL for this PR (updated for commit ac89d69):

https://animated-text-kit--pr222-example-flutter-web-bjdsj3uq.web.app

(expires Fri, 23 Apr 2021 17:05:36 GMT)

πŸ”₯ via Firebase Hosting GitHub Action 🌎

aagarwal1012 commented 3 years ago

One issue with the preview is that the default text color is black instead of white. I think this causes Wavy to show nothing (black on black). This is not necessarily an issue with this commit -- it is likely more of a web issue, but I'm pointing it out in case there is a tweak opportunity, like the web/manifest.json file.

  • Yes, I have fixed this issue, changed the wavy text background-color to purple.

The Next button on the Colorize page needs to be clicked twice. I suspect that there is a stack trace to be investigated.

  • I am not able to debug this issue, it says that Another exception was thrown: UnimplementedError.

Some of the commit activity looks related to Android, rather than Web.

  • When I was setting up the example app for the web, flutter create . created some extra files in the Android folder which seems to be necessary.

Should there be a link to the latest live page on the README?

  • Done!

Is it possible to embed the version (like in the footer) to be explicit?

  • I think this will not be useful because we already have a version badge in the Readme. Generally, app versions should be displayed in the footer, but in the case of example app, we don't maintain any version number.
aagarwal1012 commented 3 years ago

Thanks, @awhitford for the thorough review! Now I'm merging this PR.

awhitford commented 3 years ago
  • The Next button on the Colorize page needs to be clicked twice. I suspect that there is a stack trace to be investigated.

The stack trace looks like:

══║ EXCEPTION CAUGHT BY SCHEDULER LIBRARY β•žβ•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•β•
The following UnimplementedError was thrown during a scheduler callback:
UnimplementedError

When the exception was thrown, this was the stack:
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 236:49  throw_
lib/_engine/engine/canvaskit/layer_scene_builder.dart 196:5                   pushShaderMask
packages/flutter/src/rendering/layer.dart 1779:26                             addToScene
packages/flutter/src/rendering/layer.dart 407:5                               [_addToSceneWithRetainedRendering]
packages/flutter/src/rendering/layer.dart 994:14                              addChildrenToScene
packages/flutter/src/rendering/layer.dart 1966:5                              addToScene
packages/flutter/src/rendering/layer.dart 407:5                               [_addToSceneWithRetainedRendering]
packages/flutter/src/rendering/layer.dart 994:14                              addChildrenToScene
packages/flutter/src/rendering/layer.dart 1131:5                              addToScene
packages/flutter/src/rendering/layer.dart 407:5                               [_addToSceneWithRetainedRendering]
packages/flutter/src/rendering/layer.dart 994:14                              addChildrenToScene
packages/flutter/src/rendering/layer.dart 1131:5                              addToScene
packages/flutter/src/rendering/layer.dart 407:5                               [_addToSceneWithRetainedRendering]
packages/flutter/src/rendering/layer.dart 994:14                              addChildrenToScene
packages/flutter/src/rendering/layer.dart 1576:5                              addToScene
packages/flutter/src/rendering/layer.dart 732:5                               buildScene
packages/flutter/src/rendering/view.dart 217:30                               compositeFrame
packages/flutter/src/rendering/binding.dart 457:18                            drawFrame
packages/flutter/src/widgets/binding.dart 874:13                              drawFrame
packages/flutter/src/rendering/binding.dart 319:5                             [_handlePersistentFrameCallback]
packages/flutter/src/scheduler/binding.dart 1144:15                           [_invokeFrameCallback]
packages/flutter/src/scheduler/binding.dart 1082:9                            handleDrawFrame
packages/flutter/src/scheduler/binding.dart 998:5                             [_handleDrawFrame]
lib/_engine/engine/platform_dispatcher.dart 896:13                            invoke
lib/_engine/engine/platform_dispatcher.dart 145:5                             invokeOnDrawFrame
lib/_engine/engine.dart 259:45                                                <fn>
════════════════════════════════════════════════════════════════════════════════════════════════════
Another exception was thrown: UnimplementedError
Another exception was thrown: UnimplementedError
Another exception was thrown: UnimplementedError

I think this issue is related to https://github.com/flutter/flutter/issues/75495 -- but that appears to be fixed already, and should be part of stable.