aagarwal1012 / Animated-Text-Kit

🔔 A flutter package to create cool and beautiful text animations. [Flutter Favorite Package]

https://animated-text-kit.web.app

MIT License

1.66k stars 304 forks source link

Added new animated text - Flicker Animation #237

Closed CoderInTheWoods closed 3 years ago

CoderInTheWoods commented 3 years ago

Hello @aagarwal1012

I have developed a flicker glow text animation for Animated Text Kit. Kindly check this PR.

CoderInTheWoods commented 3 years ago

Kindly help me with these Errors. I am absolutely unaware of how to solve them here on Github.

aagarwal1012 commented 3 years ago

@CoderInTheWoods, please fix the tests.

aagarwal1012 commented 3 years ago

@awhitford @SirusCodes here the quick gif image for this animation in action -

codecov[bot] commented 3 years ago

Codecov Report

Merging #237 (f12878f) into master (1d31bec) will increase coverage by 0.19%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
+ Coverage   95.11%   95.31%   +0.19%     
==========================================
  Files           9       10       +1     
  Lines         430      448      +18     
==========================================
+ Hits          409      427      +18     
  Misses         21       21

Impacted Files	Coverage Δ
lib/src/flicker.dart	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1d31bec...f12878f. Read the comment docs.

CoderInTheWoods commented 3 years ago

This Deploy to Preview Channel is beyond my comprehension. Kindly acknowledge and help with the same. Rest all tests here have been passed I guess?

aagarwal1012 commented 3 years ago

Don't worry about the deployment preview test. It was meant to fail 😅

CoderInTheWoods commented 3 years ago

Okay, So now I should wait right?

For the reviewers to approve and merge?

This is my first experience with contributing to open source. Also, regarding the glow effect, should I add another such animation to the package which allows the text to have glow effect with different colors or something, ?

CoderInTheWoods commented 3 years ago

Hey! I am waiting for a PR review and merge. Let me know if I am needed to make any changes to this one.

aagarwal1012 commented 3 years ago

@CoderInTheWoods, I am just waiting for @awhitford's review.

SirusCodes commented 3 years ago

@aagarwal1012 ig we don't need Kit class

aagarwal1012 commented 3 years ago

@aagarwal1012 ig we don't need Kit class

Sorry, I completely missed this thing, @CoderInTheWoods please see #211 #216 we don't need to add AnimatedTextKit classes anymore, please update your PR.

SirusCodes commented 3 years ago

Thanks I was saying this since when🤦‍♂️

CoderInTheWoods commented 3 years ago

@aagarwal1012 ig we don't need Kit class

Sorry, I completely missed this thing, @CoderInTheWoods please see #211 #216 we don't need to add AnimatedTextKit classes anymore, please update your PR.

But how do i pass the smoke test without the kit class?

CoderInTheWoods commented 3 years ago

And i think i have already annotated the kit class as depricated

CoderInTheWoods commented 3 years ago

I am not clear as to what changes do i need to make to the code. Kindly help.

CoderInTheWoods commented 3 years ago

Hey, Kindly let me know what to do, I feel a bit lost. Where exactly do I need to make the changes? I have already used to AnimatedText class and not the Kit class in main.dart.

CoderInTheWoods commented 3 years ago

If i am not wrong, u are referring to these changes right? I have already been using this format. Kindly let me know otherwise.

CoderInTheWoods commented 3 years ago

Sure. I'll make the changes and update the PR

CoderInTheWoods commented 3 years ago

Made the changes, kindly review them.

aagarwal1012 commented 3 years ago

@all-contributors add @CoderInTheWoods for code, example, and documentation.

allcontributors[bot] commented 3 years ago

@aagarwal1012

I've put up a pull request to add @CoderInTheWoods! :tada:

CoderInTheWoods commented 3 years ago

Thanks a lot! Glad to Contribute 😁