search

aagarwal1012 / Liquid-Pull-To-Refresh

🔁 A custom refresh indicator for flutter.
https://pub.dev/packages/liquid_pull_to_refresh
MIT License
1.24k stars 92 forks source link

LPTR depends on deprecated color selectors for coloration. #60

Closed RemcoSchrijver closed 2 years ago

RemcoSchrijver commented 2 years ago

Describe the bug Starting from Flutter 2.5.0 the usage of ThemeData.accentColor is deprecated and there is still a dependency on it, creating unexpected color behaviour when tryin to change colors starting from 2.5.0.

To Reproduce

  1. Create a theme with the recommendend method of setting your Theme.colorScheme with ColorScheme.fromSwatch()
  2. LPRT does not follow this coloring.

Expected behavior LPTR to follow the coloring set int he ColorScheme field of the theme.

Flutter:

Additional context The dependency should be moved to the secondary color of the colorScheme property of Theme, see https://docs.flutter.dev/release/breaking-changes/theme-data-accent-properties

aagarwal1012 commented 2 years ago

61 fixes this issue.