PR description courtesy of Copilot, let's try this thing out 😄
This pull request includes several changes to the client/src/jobq/assembler/renderers.py file to improve the handling of package dependencies and their installation in Docker images. It also updates the test suite to ensure these changes are correctly validated. The most important changes include copying the pip list to avoid modifying the original, removing processed packages from the list, and adding new assertions in the test cases to verify the Dockerfile content.
client/src/jobq/assembler/renderers.py: Removed processed packages (wheels, requirements, build folders, and editable installs) from the pip list to ensure only the remaining packages are installed at the end. [1][2]
client/tests/smoke/test_build_from_yaml.py: Added assertions to check the presence of the base image, wheel installation, editable package install, and regular package install in the rendered Dockerfile. [1][2]
PR description courtesy of Copilot, let's try this thing out 😄
This pull request includes several changes to the
client/src/jobq/assembler/renderers.pyfile to improve the handling of package dependencies and their installation in Docker images. It also updates the test suite to ensure these changes are correctly validated. The most important changes include copying thepiplist to avoid modifying the original, removing processed packages from the list, and adding new assertions in the test cases to verify the Dockerfile content.Improvements to dependency handling:
client/src/jobq/assembler/renderers.py: Copied thepiplist to avoid modifying the original list directly.client/src/jobq/assembler/renderers.py: Removed processed packages (wheels, requirements, build folders, and editable installs) from thepiplist to ensure only the remaining packages are installed at the end. [1] [2]Updates to test cases:
client/tests/smoke/_data/docker.yaml: Added new dependencies to thepiplist in the Docker configuration for testing purposes.client/tests/smoke/test_build_from_yaml.py: Added assertions to check the presence of the base image, wheel installation, editable package install, and regular package install in the rendered Dockerfile. [1] [2]