search

aai-institute / lakefs-spec

An fsspec implementation for the lakeFS project
http://lakefs-spec.org/
Apache License 2.0
39 stars 4 forks source link

Remove hooks functionality #139

Closed nicholasjng closed 1 year ago

nicholasjng commented 1 year ago

The hook concept has been all but superseded by the new transaction API, which enables users to define a versioning workflow more naturally and make fine-grained decisions on when to do versioning, on which files etc.

Since the hooks are now only relevant for lower-level instrumentation, and we currently have no users using them, we remove them again. In a separate PR, we updated the demo notebook to use transactions everywhere, too.

Even though we only have the predefined client helpers on the transaction, which loses flexibility from the hook concept, the workflow using transactions is so superiorly readable and intuitive that most, if not all users should not be hindered.

Advertises transactions explicitly in the documentation as the tool to do versioning flows with.

nicholasjng commented 1 year ago

cc @janwillemkl

codecov-commenter commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4dcf421) 90.49% compared to head (245fc62) 88.64%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #139 +/- ## ========================================== - Coverage 90.49% 88.64% -1.86% ========================================== Files 7 6 -1 Lines 505 405 -100 Branches 64 57 -7 ========================================== - Hits 457 359 -98 + Misses 28 27 -1 + Partials 20 19 -1 ``` | [Files](https://app.codecov.io/gh/appliedAI-Initiative/lakefs-spec/pull/139?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=appliedAI-Initiative) | Coverage Δ | | |---|---|---| | [src/lakefs\_spec/\_\_init\_\_.py](https://app.codecov.io/gh/appliedAI-Initiative/lakefs-spec/pull/139?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=appliedAI-Initiative#diff-c3JjL2xha2Vmc19zcGVjL19faW5pdF9fLnB5) | `66.66% <100.00%> (ø)` | | | [src/lakefs\_spec/spec.py](https://app.codecov.io/gh/appliedAI-Initiative/lakefs-spec/pull/139?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=appliedAI-Initiative#diff-c3JjL2xha2Vmc19zcGVjL3NwZWMucHk=) | `86.80% <100.00%> (-2.22%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.