search

aai-institute / lakefs-spec

An fsspec implementation for the lakeFS project
http://lakefs-spec.org/
Apache License 2.0
39 stars 4 forks source link

Create template pull-request #206

Closed Maciej818 closed 9 months ago

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b2f0f52) 89.80% compared to head (8d554d9) 90.05%. Report is 15 commits behind head on main.

:exclamation: Current head 8d554d9 differs from pull request most recent head cfe5d94. Consider uploading reports for the commit cfe5d94 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #206 +/- ## ========================================== + Coverage 89.80% 90.05% +0.24% ========================================== Files 7 7 Lines 520 533 +13 Branches 82 85 +3 ========================================== + Hits 467 480 +13 Misses 27 27 Partials 26 26 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Maciej818 commented 9 months ago

@AdrianoKF kind request for your review. I assumed that .github directory is suitable place for PR template.

AdrianoKF commented 9 months ago

As far as I understand the documentation, PR templates can only be specified in Markdown format (which should be named .github/pull_request_template.md).

Did you see any additional docs mentioning a YAML-based template feature for PRs, @Maciej818 ?

Maciej818 commented 9 months ago

@AdrianoKF True, there is only .md option for PR (it was my wishful thinking to do this in yaml). Replaced .yaml with .md template.

AdrianoKF commented 9 months ago

@Maciej818, feel free to merge after the final touches!