aai-institute / lakefs-spec

An fsspec implementation for the lakeFS project.
http://lakefs-spec.org/
Apache License 2.0
37 stars 4 forks source link

CI: Release pipeline does not correctly set docs version #227

Closed AdrianoKF closed 6 months ago

AdrianoKF commented 6 months ago

Describe the bug

When making a new release in GitHub, the CI pipeline that publishes the documentation does not correctly pass the version number of the package being built into the mike action.

This leads to the new documentation version being labeled as latest, instead of the true version (with latest being an alias).

Note that the version is missing in the CI action output, meaning it is not being passed correctly: image

Steps to reproduce

Make a new GitHub release, let the action run, check out the published docs version (https://lakefs-spec.org/versions.json)

Expected behaviour

The docs should have a new version that matches the published Python package, and the alias latest pointing to that release.

Logs, screens, other evidence of a bug

Here's the current versions.json (note that I manually retitled the latest release already until we have a fix):

[
  {
    "version": "latest",
    "title": "v0.5.0",
    "aliases": []
  },
  {
    "version": "development",
    "title": "development",
    "aliases": []
  },
  {
    "version": "v0.4.0",
    "title": "v0.4.0",
    "aliases": []
  }
]

Your operating system

GitHub Actions

Python version

n/a

lakeFS-spec version

n/a

lakeFS server version

n/a

lakeFS SDK version

n/a

How is lakeFS deployed?

No response

Additional context

No response

Related GitHub issue(s)

Potentially https://github.com/actions/runner/issues/2788

AdrianoKF commented 6 months ago

Manually re-deployed with the correct version in 126fb70