aai-institute / lakefs-spec

An fsspec implementation for the lakeFS project.
http://lakefs-spec.org/
Apache License 2.0
37 stars 4 forks source link

Migrate the package to use the new `lakefs` SDK wrapper library #231

Closed nicholasjng closed 6 months ago

nicholasjng commented 6 months ago

Addresses #195.

Progress:

A point of contention is the client initialization. ~I removed the client configuration attributes for now, but they could be added back depending on whether we want to still support them.~ EDIT: The attributes are added back, but the configfile is pending a decision, as stated below.

As for the config file - lakefs currently only supports the default location $HOME/.lakectl.yaml, so if we take over their behavior, the configfile argument is not useful anymore until they allow other files.

codecov[bot] commented 6 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (524eb23) 90.56% compared to head (71bd77d) 91.31%.

Files Patch % Lines
src/lakefs_spec/transaction.py 95.91% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #231 +/- ## ========================================== + Coverage 90.56% 91.31% +0.75% ========================================== Files 7 5 -2 Lines 551 472 -79 Branches 93 81 -12 ========================================== - Hits 499 431 -68 + Misses 27 23 -4 + Partials 25 18 -7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nicholasjng commented 6 months ago

Hahaha, this change deletes so many lines that the new coverage falls below the current total coverage target!