Closed nicholasjng closed 6 months ago
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
524eb23
) 90.56% compared to head (71bd77d
) 91.31%.
Files | Patch % | Lines |
---|---|---|
src/lakefs_spec/transaction.py | 95.91% | 1 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hahaha, this change deletes so many lines that the new coverage falls below the current total coverage target!
Addresses #195.
Progress:
LakeFSFileSystem
LakeFSFile
lakefs_spec.config
conftest
lakefs_spec.client_helpers
LakeFSTransaction
A point of contention is the client initialization. ~I removed the client configuration attributes for now, but they could be added back depending on whether we want to still support them.~ EDIT: The attributes are added back, but the configfile is pending a decision, as stated below.
As for the config file -
lakefs
currently only supports the default location$HOME/.lakectl.yaml
, so if we take over their behavior, theconfigfile
argument is not useful anymore until they allow other files.