Closed nicholasjng closed 6 months ago
That being said, do we even need a generic abstract value with wrapt
if ininstance
checks hold anyway for placeholders? That should relax the interface typing, so point 5) might not be necessary.
EDIT: If we go that route, we should implement a value getter that raises the runtime error on an unfilled placeholder that we had previously.
I raised the remaining point 4 (better revision parsing) with treeverse in https://github.com/treeverse/lakeFS/issues/7232 - I consider this the appropriate place for the implementation (if it is happening), but we can roll our own anytime if they decide against it.
A few things were left over from the SDK wrapper migration in #231.
lakefs.Branch(...).delete_objects(*rpaths)
, bothrm_file
andrm
. See https://github.com/treeverse/lakeFS/blob/af2394abd136a1c33b7dd2d3cff29d0fde40c822/clients/python-wrapper/lakefs/branch.py#L174 and the usage example in the docstring.Branch
class, otherwise leave as is. (#240)rev_parse
for the demo than the one I made.ConcreteOrAbstract = T | Placeholder[T]
(name TBD) and use it to improveref
typing on some of the transaction APIs. (#245)LakeFSFile.details
in thewrapped_api_call
context instead of the super call in(get|put)_file
. (#240)We should also control all leftover
lakefs_sdk
imports to check if an equivalent name or better solution exists in thelakefs
package, and if so, use that instead.