aai-institute / lakefs-spec

An fsspec implementation for the lakeFS project.
http://lakefs-spec.org/
Apache License 2.0
37 stars 4 forks source link

Follow-ups of the SDK wrapper change #233

Closed nicholasjng closed 6 months ago

nicholasjng commented 6 months ago

A few things were left over from the SDK wrapper migration in #231.

We should also control all leftover lakefs_sdk imports to check if an equivalent name or better solution exists in the lakefs package, and if so, use that instead.

nicholasjng commented 6 months ago

That being said, do we even need a generic abstract value with wrapt if ininstance checks hold anyway for placeholders? That should relax the interface typing, so point 5) might not be necessary.

EDIT: If we go that route, we should implement a value getter that raises the runtime error on an unfilled placeholder that we had previously.

nicholasjng commented 6 months ago

I raised the remaining point 4 (better revision parsing) with treeverse in https://github.com/treeverse/lakeFS/issues/7232 - I consider this the appropriate place for the implementation (if it is happening), but we can roll our own anytime if they decide against it.