search

aai-institute / lakefs-spec

An fsspec implementation for the lakeFS project.
http://lakefs-spec.org/
Apache License 2.0
37 stars 4 forks source link

Implement deletes using the lakeFS branch API #236

Closed maxmynter closed 6 months ago

maxmynter commented 6 months ago

Addresses point two of #233.

codecov[bot] commented 6 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (40d2127) 91.31% compared to head (543e70c) 91.19%.

Files Patch % Lines
src/lakefs_spec/spec.py 85.71% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #236 +/- ## ========================================== - Coverage 91.31% 91.19% -0.12% ========================================== Files 5 5 Lines 472 477 +5 Branches 81 82 +1 ========================================== + Hits 431 435 +4 - Misses 23 24 +1 Partials 18 18 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nicholasjng commented 6 months ago

Note for posteriority: rm_file is now a shim to rm, which uses a lakeFS branch API designed for bulk deletions. We can thus skip covering it explicitly in tests.