Closed nicholasjng closed 6 months ago
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
a066705
) 93.39% compared to head (88a8e34
) 94.08%.
Files | Patch % | Lines |
---|---|---|
src/lakefs_spec/transaction.py | 85.71% | 0 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
As a consequence of my complaints upstream, a new
ReferenceType
was added, which is the union ofstr
and everything that marks a reference in lakefs Python code (branches, tags, commits). We now use this everywhere, as it saves space in the interfaces.Also, since the placeholder is ducktyped to be a ReferenceType always, and passes type checks at runtime (isinstance only), the typing could be relaxed to work with the native reference type only.
Part of #233.