Update pre-commit hooks, change lockfile to use uv pip compile

aai-institute / lakefs-spec

An fsspec implementation for the lakeFS project.

http://lakefs-spec.org/

Apache License 2.0

37 stars 4 forks source link

Update pre-commit hooks, change lockfile to use uv pip compile #278

Closed nicholasjng closed 1 month ago

nicholasjng commented 2 months ago

uv is much faster and thus more appropriate for a mandatory commit hook.

NB: setuptools is now in the lockfile, because uv does not have a "unsafe package exclusion" facility.

AdrianoKF commented 2 months ago

Can you also update hack/lock-deps.sh, please, @nicholasjng?

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.02%. Comparing base (b5a1f85) to head (0f7b811).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #278 +/- ## ========================================== - Coverage 94.54% 94.02% -0.52% ========================================== Files 5 5 Lines 385 385 Branches 72 72 ========================================== - Hits 364 362 -2 - Misses 13 14 +1 - Partials 8 9 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nicholasjng commented 1 month ago

So codecov fails the pipeline every time code is deleted from the repo because of the percentage changes? ¯\_(ツ)_/¯

AdrianoKF commented 1 month ago

So codecov fails the pipeline every time code is deleted from the repo because of the percentage changes? ¯_(ツ)_/¯

It's set up to prevent PRs with decreasing coverage atm. It seems that coverage actually went down in errors.py: https://app.codecov.io/gh/aai-institute/lakefs-spec/pull/278/blob/src/lakefs_spec/errors.py

It seems that one of the dependency updates might have made that else branch obsolete.

AdrianoKF commented 1 month ago

I've configured Codecov to allow PRs that decrease coverage by 1% at most in 0f7b811050fb4caf1b85954984bfb8667ea1f94d.

As discussed on Slack, the check in errors.py is still valid for older versions of the lakeFS SDK that don't include the fix in https://github.com/treeverse/lakeFS/pull/7697.