search

aajanki / yle-dl

Download videos from Yle servers
https://aajanki.github.io/yle-dl/index-en.html
GNU General Public License v3.0
309 stars 52 forks source link

Subtitles only partially downloaded #180

Closed mkarppa closed 5 years ago

mkarppa commented 5 years ago

It seems that, on the new version (20190203), when you use the ffmpeg backend (ffmpeg version 3.4.4-0ubuntu0.18.04.1), subtitles are downloaded only partially. The resulting mp4 only contains timecodes for subtitles up to about 5 minutes into the video, then nothing. This seems to affect at least the following: https://areena.yle.fi/1-4457872 https://areena.yle.fi/1-3927424 and probably more.

No errors appear in the ffmpeg output on the command line. Is this something new, or are there workarounds, anything?

edit: It seems that there is some consistency in that the subtitles are dropped after 5 minutes. No idea what's wrong, though.

aajanki commented 5 years ago

This could be due to too old ffmpeg. I have ffmpeg version 4.1-1 and I can see the subtitles for the full length of the video in both cases.

Are you able to test with the latest ffmpeg?

mkarppa commented 5 years ago

I compiled a custom build of ffmpeg 4.1, and this seems to have solved the issue, thanks.

However, I think it would be prudent to mention the fact that a sufficiently recent ffmpeg is required on the website since the version supplied with Ubuntu 18.04 LTS (including the relevant derivatives, such as Linux Mint) is too old.

edit: A recheck of the website was in order, as this seems to be mentioned now if it wasn't earlier (can't remember)...

aajanki commented 5 years ago

I added the ffmpeg version requirement on the web page a couple of days ago.

So, at the moment, the only supported way to download subtitles is to use ffmpeg 4.1. I hope to find a workaround for older ffmpegs, but let's see if that is possible.

lsolin commented 5 years ago

I went back to version 20181221 because wget works faster on my system (16.04) and I want to select external subtitles and I don't have the latest ffmpeg. Also when downloading with ffmpeg, Vlc won't play the stream until the download is ready.

Was it because of subtitle downloading problems that ffmpeg was preferred? I haven't had any of those problems for a long time.

Thanks for a great program!

Jormangeud commented 5 years ago

Also, the readme should probably mention that ffmpeg needs to be compiled with ssl support as well.

roostaq commented 5 years ago

I can confirm that for some things, it doesn't download them at all. (ex: Invisible Heroes) I am using the latest ffmepg from git://git.videolan.org/ffmpeg.git. I also tried with libav I did not put any specific flags when compiling ffmpeg. Version 20181221 works for those subs

tp0 commented 5 years ago

I think this was just fixed. See https://github.com/aajanki/yle-dl/issues/184#issuecomment-485254661

kuuntelija commented 5 years ago

Just installed version yle-dl-20190502 with ffmpeg version 4.1.3 into slackware 14.2 using slackbuilds script https://slackbuilds.org/slackbuilds/14.2/network/yle-dl.tar.gz. It has same problem as with previous version ie. no subtitles. When i use earlier version yle-dl-20181221 it loads subtitles just fine.

aajanki commented 5 years ago

@kuuntelija, can you double check that you are actually running yle-dl-20190502? (I'm asking because the slackbuilds script that you linked contains references to the version 20190331.)

If you do have the latest version, please send me the full output with the -V flag, for example: yle-dl -V https://areena.yle.fi/1-4438401. You can send the output by email because it will be quite large: antti.ajanki@iki.fi

kuuntelija commented 5 years ago

@kuuntelija, can you double check that you are actually running yle-dl-20190502? (I'm asking because the slackbuilds script that you linked contains references to the version 20190331.)

Yes it is. I used that slcakbuild script but the latest stable source from your page. It compiled just fine and command yle-dl shows yle-dl 20190502 after the usage lines.

If you do have the latest version, please send me the full output with the -V flag, for example: yle-dl -V https://areena.yle.fi/1-4438401. You can send the output by email because it will be quite large: antti.ajanki@iki.fi

Do you want also the lines when it is downloading or is before those enough?

kuuntelija commented 5 years ago

Tässäpä tämä koko debug.log. Video tuli hyvin mutta tekstitys ei ollenkaan.  

Sent: Thursday, May 09, 2019 at 9:49 PM From: "Antti Ajanki" notifications@github.com To: aajanki/yle-dl yle-dl@noreply.github.com Cc: kuuntelija lahetysikkuna@activist.com, Mention mention@noreply.github.com Subject: Re: [aajanki/yle-dl] Subtitles only partially downloaded (#180)

@kuuntelija, can you double check that you are actually running yle-dl-20190502? (I'm asking because the slackbuilds script that you linked contains references to the version 20190331.)

If you do have the latest version, please send me the full output with the -V flag, for example: yle-dl -V https://areena.yle.fi/1-4438401. You can send the output by email because it will be quite large: antti.ajanki@iki.fi

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

aajanki commented 5 years ago

Closing this issue because it seems that this is fixed by upgrading ffmpeg. If there are more subtitle issues, try to update yle-dl to the latest git version because there are more subtitle fixes.