search

aajanki / yle-dl

Download videos from Yle servers
https://aajanki.github.io/yle-dl/index-en.html
GNU General Public License v3.0
302 stars 52 forks source link

Added full_title variable in output template that does not remove series name from title #282

Closed IHeartGaming closed 2 years ago

IHeartGaming commented 2 years ago

Some episode titles are meant to include the series name. An example is the first episode of Rölli, "Rölli ja Robotti Ruttunen". Using ${title} in the output separator returns ja Robotti Ruttunen for this episode since the series name is removed. ${full_title} returns Rölli ja Robotti Ruttunen as shown on the Yle page. The --output-template help message has been updated to include ${full_title}.

aajanki commented 2 years ago

I think that this a bug in the title cleanup. A proper fix would be to change the cleanup code so that ${title} includes "Rölli" in this case. I'll see if I manage to do that.

I'd rather not add a new ${full_title} option because it would be unclear to the user. They wouldn't know when they need to use ${full_title} instead of ${title}. Therefore I'm rejecting this (but thanks for the contribution in any case!).