aajanki / yle-dl

Download videos from Yle servers
https://aajanki.github.io/yle-dl/index-en.html
GNU General Public License v3.0
309 stars 51 forks source link

Clarify license by mentioning "or later" everywhere #326

Closed oturpe closed 2 years ago

oturpe commented 2 years ago

Most places where GPL v3 is mentioned also already mention that any later version is also accepted. There were just a couple of top level files where this was not explicit. Added to avoid any unclarity about the license.

The background for this pull request is that I am attempting to package yle-dl for Fedora. Fedora requires a license review to be conducted, and initially README's plain "GPLv3" led me to believe the correct license if "GPL v3 only" — but the rest of repository content indicate it is actually "or later".

oturpe commented 2 years ago

Fedora tooling, and consequently Fedora reviewers, also complain about source files that do not have license headers, see package review comment 1. To me it is clear that all files without license headers are under the project license, however could you consider adding such headers to all source files? Apart from making such distribution reviews smoother, it also helps tracking licenses in case somebody decides to copy some of yle-dl code to another project.

aajanki commented 2 years ago

I'll add a license header to each source file.

oturpe commented 2 years ago

Thank you for review, merge and adding the headers!